labath added inline comments.
================
Comment at: lldb/docs/lldb-gdb-remote.txt:262
+send packet: jLLDBTraceSupportedType
+read packet: {"name": <name>, "description", <description>}/E<error code>
+
----------------
clayborg wrote:
> I know the deprecated trace packets allows an error code to be returned, but
> since we already have JSON being used here, I would be a shame to not return
> an error in the JSON with a string that is human readable instead of a EXX
> where XX are two hex digits. can we say the response is either:
> ```
> {"name": <name>, "description", <description>}
> ```
> or
> ```
> {"error": <error-string>}
> ```
> Or just have no error code? What would the error be able to tell us?
An error response might be suitable in case the client sends this packet
without a running process.
I think we just stick to the established error code format, which already
contains provisions for returning textual errors. I don't believe any of our
existing json packets use json-encoded errors...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90490/new/
https://reviews.llvm.org/D90490
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
