mgorny added inline comments.
Herald added a subscriber: JDevlieghere.
================
Comment at:
lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:214
+ llvm::Error error = t.CopyWatchpointsFrom(
+ static_cast<NativeThreadFreeBSD &>(*GetCurrentThread()));
+ if (error) {
----------------
mgorny wrote:
> labath wrote:
> > maybe this cast could be inside `GetCurrentThread`? Linux has it that way...
> I suppose that makes sense. I'll try it in a followup commit.
Actually, we're using this method exactly once, so I don't think it makes sense
at this point. However, I'll keep it in mind in case it becomes used more
frequently.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91032/new/
https://reviews.llvm.org/D91032
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
