teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for cleaning this up, it's really appreciated!
================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:839
+def checkObjcSupport():
+ from . import lldbplatformutil
+ if not lldbplatformutil.platformIsDarwin():
----------------
nit: we do `from lldbsuite.test import lldbplatformutil` in the surrounding
code, so that seems more consistent.
================
Comment at: lldb/test/API/functionalities/tsan/multiple/TestTsanMultiple.py:16
@expectedFailureAll(
oslist=["linux"],
----------------
mgorny wrote:
> This one's curious. I'm wondering why it's explicitly marked for all the
> platforms while it.s clearly a `.m` file ;-).
For the record: I think those XFails were just copied to all sanitizers tests
that were failing on Linux (independently of whether the issue was lacking
sanitizer support on Linux or as here Obj-C support missing).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91056/new/
https://reviews.llvm.org/D91056
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
