mnovakovic added inline comments.
================
Comment at: lldb/source/API/CMakeLists.txt:210
+ if(NOT LLDB_BUILD_FRAMEWORK)
+ set(LLDB_CLANG_RESOURCE_DIR_PARENT
"$<TARGET_PROPERTY:liblldb,LIBRARY_OUTPUT_DIRECTORY>/clang")
+ file(MAKE_DIRECTORY "${LLDB_CLANG_RESOURCE_DIR_PARENT}")
----------------
mnovakovic wrote:
> mnovakovic wrote:
> > JDevlieghere wrote:
> > > Can you check that this works in a non-framework Xcode build (or any
> > > other multi-config generator). I think the generator expressions are
> > > resolved too late.
> > Good catch and this doesn't work in a non-Framework context. I am building
> > standalone LLDB and it fails on the next line: `file(MAKE_DIRECTORY
> > "${LLDB_CLANG_RESOURCE_DIR_PARENT}")`
> >
> > That line is not even needed because line 214 builds the directory already,
> > the fix for this could be to just remove like 211 and only build directory
> > in the post_build phase.
> Actually removing the line 211 doesn't solve the issue, the failure is only
> postponed until later when the line 214 is executed (link stage looks like
> it) and it fails because `${LLDB_CLANG_RESOURCE_DIR_PARENT}` is evaluated to
> an empty string.
Looks like I can't change the comment - my bad, looks like the deleting line
211 does the trick
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88581/new/
https://reviews.llvm.org/D88581
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
