[Lldb-commits] [PATCH] D89716: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py

[Alexandre Ganea via Phabricator via lldb-commits]

aganea created this revision.
aganea added reviewers: amccarth, ted, labath.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
aganea requested review of this revision.
Herald added a subscriber: JDevlieghere.

Improve rG79809f58b02419a5d1bfb6c9a59dbd13cd038c77 
<https://reviews.llvm.org/rG79809f58b02419a5d1bfb6c9a59dbd13cd038c77> as 
suggested by @ted  :

//"`if lldbplatformutil.getPlatform() != "windows":` will check if the lldb 
platform is windows; this won’t be true if running embedded lldb tests on 
windows. Since we want to see if the host is windows, better to say `if 
sys.platform != "win32":`"//


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89716

Files:
  lldb/packages/Python/lldbsuite/test/decorators.py


Index: lldb/packages/Python/lldbsuite/test/decorators.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/decorators.py
+++ lldb/packages/Python/lldbsuite/test/decorators.py
@@ -597,7 +597,7 @@
 def skipIfWindowsAndNonEnglish(func):
     """Decorate the item to skip tests that should be skipped on non-English 
locales on Windows."""
     def is_Windows_NonEnglish(self):
-        if lldbplatformutil.getPlatform() != "windows":
+        if sys.platform != "win32":
             return None
         kernel = ctypes.windll.kernel32
         if locale.windows_locale[ kernel.GetUserDefaultUILanguage() ] == 
"en_US":



Index: lldb/packages/Python/lldbsuite/test/decorators.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/decorators.py
+++ lldb/packages/Python/lldbsuite/test/decorators.py
@@ -597,7 +597,7 @@
 def skipIfWindowsAndNonEnglish(func):
     """Decorate the item to skip tests that should be skipped on non-English locales on Windows."""
     def is_Windows_NonEnglish(self):
-        if lldbplatformutil.getPlatform() != "windows":
+        if sys.platform != "win32":
             return None
         kernel = ctypes.windll.kernel32
         if locale.windows_locale[ kernel.GetUserDefaultUILanguage() ] == "en_US":

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits