vsk added inline comments.
================
Comment at: lldb/include/lldb/Target/ThreadTrace.h:34
+ /// this thread was being executed.
+ ThreadTrace(Process &process, lldb::tid_t tid, const FileSpec trace_file)
+ : Thread(process, tid), m_trace_file(trace_file) {}
----------------
`const FileSpec &`, or just `FileSpec` might be better here.
================
Comment at: lldb/include/lldb/Target/ThreadTrace.h:34
+ /// this thread was being executed.
+ ThreadTrace(Process &process, lldb::tid_t tid, const FileSpec trace_file)
+ : Thread(process, tid), m_trace_file(trace_file) {}
----------------
vsk wrote:
> `const FileSpec &`, or just `FileSpec` might be better here.
What are the constraints on the format of "trace_file"? Is it a list of PC
ranges?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89408/new/
https://reviews.llvm.org/D89408
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
