jingham added a comment.

Thanks, that's a little better.

It would be even nicer if the DNB API's you are adding "unmask_signals" to 
would take the Context instead.  At this point they are pulling the launch 
flavor and the unmask signals from the context, so just getting the RNBContext 
would be cleaner.  If you feel motivated to make that change as well, that 
would be great.  But this is also okay as it stands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89315/new/

https://reviews.llvm.org/D89315

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to