labath added inline comments.
================
Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:269-375
+ Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_PLATFORM));
+ LLDB_LOG(log, "target {0}", target);
+
+ // If we're a remote host, use standard behavior from parent class.
+ if (!IsHost()) {
+ printf("pare\n");
+ return PlatformPOSIX::DebugProcess(launch_info, debugger, target, error);
----------------
krytarowski wrote:
> labath wrote:
> > I think it's time for a switcheroo -- move this code into
> > PlatformPOSIX::DebugProcess, and move that function into PlatformDarwin.
> Please defer any refactoring to a separate, follow up commit. Here is a lot
> of room for code deduplication, at least for ELF platforms.
I wasn't explicit in that, but I certainly did not mean for that change to be
folded into this patch. That said, preparatory patches are generally better
than follow-up changes for these kinds of things. Doing it later means that the
commit will be larger than necessary (and creates the risk of the change not
materializing).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88796/new/
https://reviews.llvm.org/D88796
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
