clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land.
Just one nit about forward declaring the TraceDumpOptions. ================ Comment at: lldb/include/lldb/Target/Target.h:32 #include "lldb/Target/ThreadSpec.h" +#include "lldb/Target/Trace.h" #include "lldb/Utility/ArchSpec.h" ---------------- Add TraceDumpOptions to lldb-forward.h and then this won't be needed here. Anytime you only have pointers or references to objects in headers, we should use forward declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86670/new/ https://reviews.llvm.org/D86670 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
