compnerd created this revision.
compnerd added reviewers: JDevlieghere, kastiglione.
compnerd added a project: LLDB.
compnerd requested review of this revision.
The OS version field is generally not very helpful for non-Darwin
targets. On Linux, it identifies the kernel version which moves
out-of-sync with the userspace. On Windows, this field actually ends up
corresponding to the Visual Studio toolset version instead of the OS
version. Consider non-Darwin targets without an OS version to be fully
specified.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D88181
Files:
lldb/source/Utility/ArchSpec.cpp
Index: lldb/source/Utility/ArchSpec.cpp
===================================================================
--- lldb/source/Utility/ArchSpec.cpp
+++ lldb/source/Utility/ArchSpec.cpp
@@ -1426,7 +1426,8 @@
if ((user_specified_triple.getVendor() != llvm::Triple::UnknownVendor) ||
TripleVendorWasSpecified()) {
const unsigned unspecified = 0;
- if (user_specified_triple.getOSMajorVersion() != unspecified) {
+ if (!user_specified_triple.isOSDarwin() ||
+ user_specified_triple.getOSMajorVersion() != unspecified) {
user_triple_fully_specified = true;
}
}
Index: lldb/source/Utility/ArchSpec.cpp
===================================================================
--- lldb/source/Utility/ArchSpec.cpp
+++ lldb/source/Utility/ArchSpec.cpp
@@ -1426,7 +1426,8 @@
if ((user_specified_triple.getVendor() != llvm::Triple::UnknownVendor) ||
TripleVendorWasSpecified()) {
const unsigned unspecified = 0;
- if (user_specified_triple.getOSMajorVersion() != unspecified) {
+ if (!user_specified_triple.isOSDarwin() ||
+ user_specified_triple.getOSMajorVersion() != unspecified) {
user_triple_fully_specified = true;
}
}
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
