jingham added a comment.

Calling every symbol called mmap you find around till one returns some value 
makes me a bit nervous.  For instance, on macOS dyld has a symbol called "mmap" 
that isn't meant to be called by anybody but dyld.  We probably don't want to 
accidentally call that.

You can get around that particular instance by only looking for exported 
functions (macOS's internal mmap is not exported).  I can't think of any good 
reason we would want to call an unexported mmap, since we're trying to do what 
a program on the system would do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87868/new/

https://reviews.llvm.org/D87868

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to