shafik added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:83 + + AttributeValue(const DWARFUnit *_cu, dw_offset_t _die_offset, + dw_attr_t _attr, dw_form_t _form) ---------------- aprantl wrote: > We usually don't prefix constructor arguments. Most LLDB code would write > this as > m_cu(cu) for classes and cu(cu) for structs. Why not drop the prefixes all together? I don't see what they add here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87441/new/ https://reviews.llvm.org/D87441 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
