labath added a comment.

The new API looks fairly confusing. This doesn't sound like something that the 
SB users should generally know or care about. What would the GetByteOffset 
function return in the generic case?
I don't find the explanation in the summary convincing. Presumably, you should 
be able to verify the proper behavior by checking the data (and its size) that 
the SBValue object holds. If that returns the right thing, who cares about the 
value of the offset field?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82865/new/

https://reviews.llvm.org/D82865

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to