labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
I originally thought we would keep the original macro capitalization (similar to how `llvm/BinaryFormat/elf.h` maintains the elf.h capitalizations even though it does not define these symbols as macros). I still think that would be a good idea, but I don't mind the current version either. If you do keep the current version, then I think we should also change the namespace name to lower case (`sve::`). ================ Comment at: lldb/source/Plugins/Process/Utility/LinuxPTraceDefines_arm64sve.h:22 * - * See linux/Documentation/arm64/sve.txt for a description of the VL/VQ + * See Linux kernel Documentation/s/sve.rst for a description of the vl/vq * terminology. ---------------- too aggressive search&replace ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85641/new/ https://reviews.llvm.org/D85641 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits