labath added a comment. The changes don't seem contentious to me, though I am also not very familiar with this code.
What surprised me was the `OptionGroupPlatform` argument to `TargetList::CreateTargetInternal`. It seems like a slighly unusual thing to have, as that means the equivalent SB call would have to construct an OptionGroup object even though it has nothing to do with CLI. But that is not a problem caused by this patch... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84809/new/ https://reviews.llvm.org/D84809 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
