dblaikie added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1044
for (const llvm::DWARFDebugLine::Sequence &seq : line_table->Sequences) {
+ if (!list.ContainsFileAddressRange(seq.LowPC, seq.HighPC - seq.LowPC))
+ continue;
----------------
Could you specifically look for/propagate tombstones here, to reduce the risk
of large functions overlapping with the valid address range, even when they're
tombstoned to zero? (because zero+large function size could still end up
overlapping with valid code)
To do that well, I guess it'd have to be implemented at a lower-layer, inside
the line table state machine - essentially dropping all lines derived from a
"set address" operation that specifies a tombstone.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84402/new/
https://reviews.llvm.org/D84402
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
