jingham requested changes to this revision.
jingham added a comment.

We certainly don't want to clear the shared module cache when the Debugger or 
the SBDebugger is destroyed.  Most IDE's that use LLDB as a library use a 
debugger per debugging session, and destroy the debugger when the debugging 
session ends.  As it stands now, when the first debugging session ends we don't 
remove any of the already parsed modules, so that the second debugging session 
is much faster.  That would not be true if you did RemoveOrphanedSharedModules 
in Debugger::Destroy.  99% of all the libraries that get loaded by an app don't 
change over an Xcode run, and are in fact shared among most of the targets you 
might debug on a given platform.  So clearing the cache after every run would 
result in a lot of pointless reparsing of system libraries.

The choice to clear the shared module cache should always be left up to the 
client.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83876/new/

https://reviews.llvm.org/D83876



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to