labath added a comment.

The idea seems ok (though could use a test), but I am wondering if it wouldn't 
be better to do this conversion during (or immediately after) parsing. If I 
remember the previous discussions correctly, we've established that the 
value/invalidate_regs fields in the RegisterInfo structs are expected to 
contain "lldb" register numbers, but that the natural thing to do in the 
target.xml is to transfer "process plugin" (i.e., the `regnum` field) in these 
fields.

If that's true, then it would be better to do the conversion during parsing, so 
that we don't violate any invariants that some other parts of code may be 
assuming.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77043/new/

https://reviews.llvm.org/D77043



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to