teemperor accepted this revision. teemperor added a comment. LGTM too, thanks!
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1339 + TypeSystemClang::CompleteTagDeclarationDefinition(type); + const auto *td = TypeSystemClang::GetQualType(type.GetOpaqueQualType()) + .getTypePtr() ---------------- shafik wrote: > This has to be a `TagDecl` so why use `auto`? `const TagDecl *td = ClangUtil::GetAsTagDecl(type);` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83199/new/ https://reviews.llvm.org/D83199 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits