labath added a subscriber: teemperor. labath accepted this revision. labath added a comment.
If this didn't show up on the lldb benchmark charts (https://teemperor.de/lldb-bench/static.html), it would be nice to add a benchmark for this. What exactly were you measuring here? ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:191-192 + LLDB_LOG_ERROR(log, std::move(e), + "SymbolFileDWARF::ParseSupportFiles failed to parse " + "line table prologue"); + }, ---------------- It would be good to also add a `{0}` somewhere to print the actual error we received. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81589/new/ https://reviews.llvm.org/D81589 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
