vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Lgtm, thanks.
================
Comment at: lldb/test/API/lit.cfg.py:102
+if 'DYLD_INSERT_LIBRARIES' in config.environment and platform.system() ==
'Darwin':
+ config.python_executable = find_python_interpreter()
+
----------------
JDevlieghere wrote:
> vsk wrote:
> > What does setting python_executable do? I looked this up in llvm and found:
> >
> > ```
> > test/lit.cfg.py: ('%llvm-locstats', "'%s' %s" %
> > (config.python_executable, llvm_locstats_tool)))
> > test/lit.site.cfg.py.in:config.python_executable = "@PYTHON_EXECUTABLE@"
> > test/tools/UpdateTestChecks/lit.local.cfg:
> > config.python_executable, script_path, extra_args)))
> > ```
> >
> > Am I missing something, or does something here translate into a lit
> > directive to run python files under python_interpreter?
> `test/lit.site.cfg.py.in` will be configured with the path to the real python
> executable in the build dir.
This is what I was missing: `lldb/test/API/lldbtest.py: executable =
test.config.python_executable`.
================
Comment at: lldb/test/API/lldbtest.py:51
# build with.
executable = test.config.python_executable
----------------
.. so by the time this is reached, executable should point to a known-good
python binary.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81696/new/
https://reviews.llvm.org/D81696
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
