labath added a comment.

I'm pretty indifferent about this functionality -- I don't think it hurts, but 
it also doesn't seem like a pressing problem that needs addressing.

Regarding the implementation, be aware that assertion failures during test 
teardown are reproted pretty weirdly -- IIRC at this point the test has already 
been declared "successful", and these failures manifest as "CLEANUP ERROR"s 
somewhere. And I have a feeling they don't actually fail the check-lldb 
command. I don't know if this is due to something we've done, or if it's just 
how the python unittest framework works...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81612/new/

https://reviews.llvm.org/D81612



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to