JDevlieghere marked 4 inline comments as done.
JDevlieghere added inline comments.
================
Comment at: lldb/include/lldb/Utility/Stream.h:402-403
+ bool has_colors() const override { return true; }
+
uint64_t current_pos() const override {
----------------
labath wrote:
> This is not consistent with the intend of this method (`This function
> determines if this stream is displayed and supports colors.`). One could
> argue whether this could be "true" for CommandObjectResult streams which are
> destined to be later printed to a terminal, but it's definitely not a good
> default.
>
> However, all of that is irrelevant, as this should not be needed anymore. Is
> that correct?
Correct!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81058/new/
https://reviews.llvm.org/D81058
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
