jingham added a comment.

I thought I was just repeating your original description of the problem in a 
scenario orchestrated by breakpoint actions.  I must have missed something in 
your description if it's true that the scenario I described doesn't match your 
initial problem.  But regardless, if there was a problem you should be able to 
actually drive lldb, either through the command-line or the SB API to the point 
of failure.  And if so, you should be able to write a test that does the same 
thing.

IIUC the flow of this revision, the fix is no longer going to be monkeying with 
private stop reasons, but rather just avoiding suspended threads in the 
DoOnRemoval part of the stop event handling.  That makes it harder to test with 
the sort of unit test you proposed, but again, it sounds like the problem you 
described was fairly straightforward to produce, so writing a test that asserts 
the behavior you want out of that scenario should be straightforward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80112/new/

https://reviews.llvm.org/D80112



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to