jarin marked an inline comment as done.
jarin added inline comments.

================
Comment at: lldb/source/API/SBTarget.cpp:1593
+      llvm::StringRef rest =
+          UUID::DecodeUUIDBytesFromString(uuid_str, bytes, 20);
+      // If the UUID string was consumed and it is not empty, let us use it for
----------------
The four lines above should perhaps be a method of UUID. Something like 
SetFromStringRef, but for any size. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80755/new/

https://reviews.llvm.org/D80755



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to