+ Walter

On Fri, May 22, 2020 at 1:07 PM Jonas Devlieghere via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

>
> Author: Jonas Devlieghere
> Date: 2020-05-22T13:07:10-07:00
> New Revision: a67b2faa7c4cfbceffb4213f46769c45a5a9291a
>
> URL:
> https://github.com/llvm/llvm-project/commit/a67b2faa7c4cfbceffb4213f46769c45a5a9291a
> DIFF:
> https://github.com/llvm/llvm-project/commit/a67b2faa7c4cfbceffb4213f46769c45a5a9291a.diff
>
> LOG: [lldb/Test] Disable APITests.exe on Windows
>
> The generated binary (APITests.exe) is not a valid googletest binary. I
> suspect it has something to do with us linking against liblldb.
>
> Added:
>
>
> Modified:
>     lldb/unittests/CMakeLists.txt
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/lldb/unittests/CMakeLists.txt b/lldb/unittests/CMakeLists.txt
> index eab053f03650..42aa2c2d7567 100644
> --- a/lldb/unittests/CMakeLists.txt
> +++ b/lldb/unittests/CMakeLists.txt
> @@ -59,7 +59,10 @@ function(add_unittest_inputs test_name inputs)
>  endfunction()
>
>  add_subdirectory(TestingSupport)
> -add_subdirectory(API)
> +if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows")
> +  # FIXME: APITests.exe is not a valid googletest binary.
> +  add_subdirectory(API)
> +endif()
>  add_subdirectory(Breakpoint)
>  add_subdirectory(Core)
>  add_subdirectory(DataFormatter)
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to