I set the timeouts low just to keep the test from taking too long. Beyond that there’s no harm in bumping them up till they pass consistently.
I messed with the timeouts and reran the test a bunch of times till it was stable for me, but I have a pretty fast mac, so apparently that wasn’t a good test… I don’t see a way to do this without timeouts, however… Thanks for fixing this. Jim > On May 22, 2020, at 3:47 AM, Pavel Labath via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > > Author: Pavel Labath > Date: 2020-05-22T12:47:34+02:00 > New Revision: 053b0634ea93b1ed7993adf34730bd752e9d84ec > > URL: > https://github.com/llvm/llvm-project/commit/053b0634ea93b1ed7993adf34730bd752e9d84ec > DIFF: > https://github.com/llvm/llvm-project/commit/053b0634ea93b1ed7993adf34730bd752e9d84ec.diff > > LOG: [lldb] Increase timeout in TestExitDuringExpression > > 200 microseconds is not enough time for any expression to execute > reliably. On linux, calling pthread_exit can result in call to dlopen, > which cannot complete in that time, particularly when running under a > debugger. > > On linux, this test failed all the time, on macos, about two thirds of > runs were failing. This patch increases the timeout to 100ms, which is > enough to get it passing reliably on linux, though I wouldn't be > surprised if an even bigger timeout would be needed for remote test > runs. > > Added: > > > Modified: > lldb/test/API/functionalities/thread/exit_during_expression/main.c > > Removed: > > > > ################################################################################ > diff --git > a/lldb/test/API/functionalities/thread/exit_during_expression/main.c > b/lldb/test/API/functionalities/thread/exit_during_expression/main.c > index 66b6018976cf..a3bf53915a03 100644 > --- a/lldb/test/API/functionalities/thread/exit_during_expression/main.c > +++ b/lldb/test/API/functionalities/thread/exit_during_expression/main.c > @@ -3,7 +3,7 @@ > #include <stdio.h> > #include <unistd.h> > > -static unsigned int g_timeout = 200; > +static unsigned int g_timeout = 100000; > > int function_to_call() { > > > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
