JDevlieghere added a comment. In D80112#2050127 <https://reviews.llvm.org/D80112#2050127>, @fallkrum wrote:
> In D80112#2049657 <https://reviews.llvm.org/D80112#2049657>, @JDevlieghere > wrote: > > > In D80112#2048805 <https://reviews.llvm.org/D80112#2048805>, @fallkrum > > wrote: > > > > > Anybody there? Do you see me? > > > > > > Unless this change is somehow urgent, the common courtesy ‘ping’ rate is > > once a week [1][2]. I'm sure Jim or Greg will take a look when they can. > > > > Would it be possible to add a test for this so it doesn't regress in the > > future? For example a test that would fail with TSan would be sufficient. > > > > [1] https://llvm.org/docs/Contributing.html#how-to-submit-a-patch > > [2] > > https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity > > > Thanks for the answer, I don't think it is urgent. You're welcome! > Are there any docs on how to write tests for lldb? I found unit tests > (lldb/unittests) written in c++ and tests (lldb/test) written in Python. > Tried to find tests for Thread class to add check for my editing but there > is no such a tests. It is very unclear for me in which way TSan > can be helpful in this situation? The lldb website [1] contains an overview of the high level structure of the test suite. For a new test I usually either start form the example or from an existing tests. Ignore my TSan comment, I didn't pay enough attention reading the description, I thought this was fixing a race in lldb. [1] https://lldb.llvm.org/resources/test.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
