imaihal marked 2 inline comments as done.
imaihal added inline comments.
================
Comment at: mlir/lib/ExecutionEngine/ExecutionEngine.cpp:123
}
- std::unique_ptr<llvm::TargetMachine> machine(
- target->createTargetMachine(targetTriple, "generic", "", {}, {}));
+ std::string cpu = std::string(llvm::sys::getHostCPUName());
+ llvm::SubtargetFeatures features;
----------------
mehdi_amini wrote:
> You should be able to write just `std::string cpu =
> llvm::sys::getHostCPUName();`? (Or `std::string
> cpu(llvm::sys::getHostCPUName());`)
I write ` std::string cpu(llvm::sys::getHostCPUName());` because `std::string
cpu = llvm::sys::getHostCPUName();` issued build error. Thanks for your review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80130/new/
https://reviews.llvm.org/D80130
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
