Author: Vedant Kumar Date: 2020-05-05T09:18:35-07:00 New Revision: c05f35443c3bc6dc69e060c766b23669a33e14ac
URL: https://github.com/llvm/llvm-project/commit/c05f35443c3bc6dc69e060c766b23669a33e14ac DIFF: https://github.com/llvm/llvm-project/commit/c05f35443c3bc6dc69e060c766b23669a33e14ac.diff LOG: [lldb/unittest] Avoid relying on compiler character encoding in unicode test This is a speculative fix for a unit test failure on a Win/MSVC2017 bot (http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/16106/steps/test/logs/stdio). Added: Modified: lldb/unittests/DataFormatter/StringPrinterTests.cpp Removed: ################################################################################ diff --git a/lldb/unittests/DataFormatter/StringPrinterTests.cpp b/lldb/unittests/DataFormatter/StringPrinterTests.cpp index 4b01f5c1dbe2..180b13772af5 100644 --- a/lldb/unittests/DataFormatter/StringPrinterTests.cpp +++ b/lldb/unittests/DataFormatter/StringPrinterTests.cpp @@ -74,8 +74,8 @@ TEST(StringPrinterTests, CxxASCII) { EXPECT_EQ(fmt("🥑"), QUOTE("🥑")); // Octal (\nnn), hex (\xnn), extended octal (\unnnn or \Unnnnnnnn). - EXPECT_EQ(fmt("\uD55C"), QUOTE("한")); - EXPECT_EQ(fmt("\U00010348"), QUOTE("𐍈")); + EXPECT_EQ(fmt("\uD55C"), QUOTE("\uD55C")); + EXPECT_EQ(fmt("\U00010348"), QUOTE("\U00010348")); // FIXME: These strings are all rejected, but shouldn't be AFAICT. LLDB finds // that these are not valid utf8 sequences, but that's OK, the raw values @@ -111,8 +111,8 @@ TEST(StringPrinterTests, CxxUTF8) { EXPECT_EQ(fmt("🥑"), QUOTE("🥑")); // Octal (\nnn), hex (\xnn), extended octal (\unnnn or \Unnnnnnnn). - EXPECT_EQ(fmt("\uD55C"), QUOTE("한")); - EXPECT_EQ(fmt("\U00010348"), QUOTE("𐍈")); + EXPECT_EQ(fmt("\uD55C"), QUOTE("\uD55C")); + EXPECT_EQ(fmt("\U00010348"), QUOTE("\U00010348")); // FIXME: These strings are all rejected, but shouldn't be AFAICT. LLDB finds // that these are not valid utf8 sequences, but that's OK, the raw values @@ -148,8 +148,8 @@ TEST(StringPrinterTests, SwiftUTF8) { EXPECT_EQ(fmt("🥑"), QUOTE("🥑")); // Octal (\nnn), hex (\xnn), extended octal (\unnnn or \Unnnnnnnn). - EXPECT_EQ(fmt("\uD55C"), QUOTE("한")); - EXPECT_EQ(fmt("\U00010348"), QUOTE("𐍈")); + EXPECT_EQ(fmt("\uD55C"), QUOTE("\uD55C")); + EXPECT_EQ(fmt("\U00010348"), QUOTE("\U00010348")); // FIXME: These strings are all rejected, but shouldn't be AFAICT. LLDB finds // that these are not valid utf8 sequences, but that's OK, the raw values _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
