labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Thanks. LGTM, assuming the checked-in core files are of a "reasonable" (~ several tens of KB) size. ================ Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:51 lldb::offset_t offset = reg_info->byte_offset; - uint64_t v = m_gpr.GetMaxU64(&offset, reg_info->byte_size); - if (offset == reg_info->byte_offset + reg_info->byte_size) { - value = v; - return true; + if (offset < GetGPRSize() && offset < m_gpr.GetByteSize()) { + uint64_t v = m_gpr.GetMaxU64(&offset, reg_info->byte_size); ---------------- I guess all of these conditions should really be `offset + reg_info->byte_size <= GetGPRSize()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77793/new/ https://reviews.llvm.org/D77793 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits