teemperor added a comment.
I'm not sure I understand why are we not adding the property to the lookup ptr?
I would assume we would call addDecl to it which should make it visible and I
don't see any ObjCPropertyDecl (?) check in that code?
================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:348
+ if (auto *nd = llvm::dyn_cast<clang::NamedDecl>(member))
+ if (auto *dc = llvm::dyn_cast<clang::DeclContext>(parent)) {
+ // This triggers ExternalASTSource::FindExternalVisibleDeclsByName() to
be
----------------
SetMemberOwningModule is called really often and these two conditions are
always met in our code, so we are now constantly resetting
setHasExternalVisibleStorage to true?
================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:351
+ // called when searching for members.
+ dc->setHasExternalLexicalStorage(true);
+ dc->setHasExternalVisibleStorage(true);
----------------
You shouldn't need this to get FindExternalVisibleDeclsByName and all this
seems to work without it?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78333/new/
https://reviews.llvm.org/D78333
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
