labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/scripts/reproducer-replay.py:1
+#! /usr/bin/env python3
+
----------------
JDevlieghere wrote:
> This is needed for the timeout. I'd rather not rely on an external package
> for this unless anyone objects.
SGTM. Hopefully will get rid of py2 soon, and this isn't a very critical piece
of infrastructure.
================
Comment at: lldb/scripts/reproducer-replay.py:50
+ if dir.startswith('Test') and extension == '.py':
+ reproducers.append(os.path.join(root, dir))
+ return reproducers
----------------
it would probably be slightly cleaner to make this a generator and use `yield
os.path.join(root, dir)`
================
Comment at: lldb/scripts/reproducer-replay.py:86
+ else:
+ path = tempfile.gettempdir()
+
----------------
I'm not sure how useful is this now that we don't put reproducers in `/tmp`
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77608/new/
https://reviews.llvm.org/D77608
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
