vsk marked an inline comment as done.
vsk added inline comments.
================
Comment at: lldb/source/DataFormatters/StringPrinter.cpp:126
case 0:
- retval = {"\\0", 2};
- break;
+ return {"\\0", 2};
case '\a':
----------------
aprantl wrote:
> We have a lot of implementations of this function all over our projects (`git
> grep '\\\\r' llvm/lib`) that we might want to factor this into a support
> function.
I do see another utf decoder implementation in YAMLParser, but it's different
enough from lldb's that I'd prefer to hold off on attempting to unify these for
some later patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77843/new/
https://reviews.llvm.org/D77843
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
