labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks fine, modulo the assert fail
================
Comment at: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp:275
+ for (size_t i = 0; i < module_specs.GetSize(); ++i) {
+ assert(module_specs.GetModuleSpecAtIndex(i, spec));
+ if ((uuid == nullptr ||
----------------
this assert has side effects. that won't work in no-assert builds
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77337/new/
https://reviews.llvm.org/D77337
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
