aprantl marked an inline comment as done. aprantl added inline comments.
================ Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1260 + + module->Name = name.str(); + return ast_source->RegisterModule(module); ---------------- teemperor wrote: > Why is that done? The module should already have the correct name when it is > returned from findOrCreateModule (where we pass the same name and then create > the new module with that name). > > If this line is removed, do we still need D75561? Good catch! This is a leftover from my first version of the patch where I created the Module object manually without instantiating a clang::ModuleMap. ================ Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1256 + name, + parent_desc ? const_cast<clang::Module *>(parent_desc->getModuleOrNull()) + : nullptr, ---------------- here ^^ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75488/new/ https://reviews.llvm.org/D75488 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
