teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

Could you make the `uint32_t` a typedef? I'm fine with this not being 
type-safe, but a typedef would at least allow me to search for where this 
information is used. Grepping/searching for `uint32_t` isn't a great 
experience. It would also make this interface more self-documenting.

Beside that LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75562/new/

https://reviews.llvm.org/D75562



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to