[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik updated this revision to Diff 250083.
shafik added a comment.

Moving to using `assertIn` as suggest in comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76080/new/

https://reviews.llvm.org/D76080

Files:
  lldb/packages/Python/lldbsuite/test/lldbtest.py


Index: lldb/packages/Python/lldbsuite/test/lldbtest.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -2421,8 +2421,9 @@
         eval_result = frame.EvaluateExpression(expr, options)
 
         if error_msg:
-            self.assertFalse(eval_result.IsValid(), "Unexpected success with 
result: '" + str(eval_result) + "'")
-            self.assertEqual(error_msg, eval_result.GetError().GetCString())
+            self.assertTrue(eval_result.IsValid(), "Result is not valid")
+            self.assertTrue(eval_result.GetError().Fail(), "Unexpected 
success...")
+            self.assertIn(error_msg,eval_result.GetError().GetCString())
             return
 
         if not eval_result.GetError().Success():



Index: lldb/packages/Python/lldbsuite/test/lldbtest.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -2421,8 +2421,9 @@
         eval_result = frame.EvaluateExpression(expr, options)
 
         if error_msg:
-            self.assertFalse(eval_result.IsValid(), "Unexpected success with result: '" + str(eval_result) + "'")
-            self.assertEqual(error_msg, eval_result.GetError().GetCString())
+            self.assertTrue(eval_result.IsValid(), "Result is not valid")
+            self.assertTrue(eval_result.GetError().Fail(), "Unexpected success...")
+            self.assertIn(error_msg,eval_result.GetError().GetCString())
             return
 
         if not eval_result.GetError().Success():

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits