shafik added inline comments.
================
Comment at: lldb/include/lldb/Symbol/CompilerType.h:236
// type is valid and the type system supports typedefs, else return an
- // invalid type.
+ // invalid type. The payload argument is the typesystem-specific Type
payload.
CompilerType CreateTypedef(const char *name,
----------------
Why not convert this comment style?
================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:6965
+ member->setFromASTFile();
+ member->setOwningModuleID(id);
+ }
----------------
Do we also need to make sure `setModuleOwnershipKind(...)` is consistent?
================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:71
+ void SetOwningModuleID(unsigned id) {
+ assert(id < ObjCClassBit);
+ bool is_complete = IsCompleteObjCClass();
----------------
So we at least expect the last bit to be available, do we expect to add more
bits like `ObjCClassBit`, how many do we expect to have available?
I guess conversely what range do we expect `id` to fit in?
Does it make sense to document this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75488/new/
https://reviews.llvm.org/D75488
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
