labath added a comment.
Thanks for adding the tests. They look good. Could you split them off into a
separate patch? I believe @teemperor wanted (and I do agree it's a good idea)
to check them in first in order to demonstrate that this patch does not change
the behavior (or to make it what exactly changes).
================
Comment at: lldb/unittests/Utility/RangeMapTest.cpp:22
+const std::vector<uint32_t> FindEntryIndexes(uint32_t address,
+ RangeDataVectorT map) {
----------------
returning a const value from a function is fairly useless. All it does is make
the caller jump through some hoops if he really wants to modify it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74759/new/
https://reviews.llvm.org/D74759
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
