labath marked an inline comment as done. labath added inline comments.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:429 + /// Use qOffsets to query the offset used when relocating the target + /// executable. Currently, we only support relocating all sections by the same + /// amount. ---------------- clayborg wrote: > So I am not advocating supporting the full QOffsets packet at all. Just > splitting up the contents of GetExecutableOffset so that GetQOffsets() grabs > the exact output and chops it up. No need to implement any true > functionality. So the code would be identical to what you have, but the > GetQOffsets() will just return the array of strings that contains the chopped > up return value. Since this class is GDBRemoteCommunicationClient, and if > someone new comes in and wants the results of QOffsets to do something, the > code is already there. Right now is implemented, but hidden inside > GetExecutableOffset. So no functionality, just have GetQOffsets() return the > data from the packet. Let me know what you think. Not a blocker, I would just > prefer that any packet that GDB remote protocol handles has a raw access > function. Ok, I see what you mean. The new patch now has a function which extracts all the data from the qOffsets response. I was trying to avoid doing that (I could take some shortcuts if I assumed all offsets have to be same), but overall difference is not that big.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74598/new/ https://reviews.llvm.org/D74598 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
