clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

If we are going to use this to to ansi stuff we should ensure the suffix works 
too. The current testing example will turn the line green along with all lines 
that follow if all other ansi stuff is removed. Right now I am guessing we are 
getting lucky because something else is doing the ansi reset. Once that is 
tested, this will be good to go.



================
Comment at: lldb/test/Shell/Settings/TestLineMarkerColor.test:4
+settings set use-color true
+settings set stop-show-line-ansi-prefix ""
+b foo
----------------
test suffix?


================
Comment at: lldb/test/Shell/Settings/TestLineMarkerColor.test:8
+c
+settings set stop-show-line-ansi-prefix ${ansi.fg.green}
+run
----------------
test suffix?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75070/new/

https://reviews.llvm.org/D75070



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to