JDevlieghere added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h:66 /// Non-null value means we haven't built the index yet. + SymbolFileDWARF *m_dwarf; ---------------- labath wrote: > JDevlieghere wrote: > > This seems inverted? > Actually, it is correct, although somewhat confusing -- the member is set to > nullptr once we finished indexing. I think I can rephrase that comment to be > a bit clearer.. I see, thanks. I think that would help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74964/new/ https://reviews.llvm.org/D74964 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
