labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
This is great now, thanks for bearing with me.
================
Comment at: lldb/bindings/interface/SBProcess.i:350
+ %feature("autodoc", "
+ Returns the platform's process extended crash information.")
GetExtendedCrashInformation;
+ lldb::SBStructuredData
----------------
Mentioning the platform just confuses things here IMO. Maybe we can just remove
it now?
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h:89
llvm::Expected<lldb_private::StructuredData::DictionarySP>
- FetchExtendedCrashInformation(lldb_private::Target &target) override;
+ FetchExtendedCrashInformation(lldb_private::Process& process) override;
----------------
Please run clang-format on this patch. the `&` should bind to the variable, not
the type.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75049/new/
https://reviews.llvm.org/D75049
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
