mib marked 2 inline comments as done.
mib added inline comments.

================
Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1574-1577
+            interpreter, "platform process",
+            "Commands to query, launch and attach to "
+            "processes on the current platform.",
+            "platform process [attach|launch|list|crash-info] ...") {
----------------
labath wrote:
> I am not sure if this command really belongs here. If definitely doesn't fit 
> the description "Commands to query, launch and attach to processes on the 
> current platform.", and if you look at the subcommands, you see that these 
> are all things that you do *before* you get an actual running process. 
> "crash-info" is the exact opposite -- it only makes sense *after* you have a 
> process.
> 
> The "process" (where you had it originally) command tree contains commands 
> for interaction with a running process (although it also overlaps these 
> commands somewhat :/). This command is pretty similar to "process status" so 
> I think it makes sense for it to be next to it (in fact, it is so similar, 
> that I'd consider putting this under some "verbose" switch of process status).
I misunderstood your request. I'm moving it under "process status --verbose".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74657/new/

https://reviews.llvm.org/D74657



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to