> On Feb 19, 2020, at 17:52, Frédéric Riss <fr...@apple.com> wrote:
>
>
>
>> On Feb 19, 2020, at 5:44 PM, Davide Italiano via lldb-commits
>> <lldb-commits@lists.llvm.org> wrote:
>>
>>
>>
>>> On Feb 19, 2020, at 17:34, Jonas Devlieghere via lldb-commits
>>> <lldb-commits@lists.llvm.org> wrote:
>>>
>>>
>>> Author: Jonas Devlieghere
>>> Date: 2020-02-19T17:34:01-08:00
>>> New Revision: 6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4
>>>
>>> URL:
>>> https://github.com/llvm/llvm-project/commit/6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4
>>> DIFF:
>>> https://github.com/llvm/llvm-project/commit/6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4.diff
>>>
>>> LOG: [lldb/Test] Skip VSCode test on embedded Darwin
>>>
>>> These tests are not configured to run on the device.
>>
>>
>> I’ve never seen these failing. Did you?
>
> Yes, I did. All of them fail for me and 2 of them hang.
>
> `@skipIfDarwinEmbedded` obviously works for us, but I’m wondering if
> `@skipIfRemote` would not be a better/more generic fix?
@skipIfRemote is obviously a better fix.
It would be nice if all the vscode tests could be categorized and we could put
a single annotation on them, so that in case somebody adds another test, we
don’t have to do this decorator gymnastics.
—
Davide
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
