clayborg added a comment. In D74798#1883015 <https://reviews.llvm.org/D74798#1883015>, @JDevlieghere wrote:
> In D74798#1882994 <https://reviews.llvm.org/D74798#1882994>, @ivanhernandez13 > wrote: > > > I added the test file but atm the two existing arguments > > (--wait-for-debugger and --port) will cause lldb-vscode to hang and await > > some sort of action from an external process causing the test runner to > > hang. I added a single test case for handling an invalid port since that > > will cause the process to exit immediately but not certain on how to handle > > the other cases. > > > I think for these particular cases it's sufficient to check the help output > and make sure the flags are there. yeah just test for the options themselves in the help output. --wait-for-debugger is only when you need to debug lldb-vscode's initial packets with a debugger, so it is not a user facing argument. We might choose to hide this option by default. I know LLVM option parsing can do this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74798/new/ https://reviews.llvm.org/D74798 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
