dstenb added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:870
if (MI->isCandidateForCallSiteEntry() &&
- DAG->getTarget().Options.EnableDebugEntryValues)
+ DAG->getTarget().Options.SupportsDebugEntryValues)
MF.addCallArgsForwardingRegs(MI, DAG->getSDCallSiteInfo(Node));
----------------
djtodoro wrote:
> dstenb wrote:
> > I'm sorry for commenting on this so late, but when now adapting this patch
> > for our downstream target, for which we will not enable call site info by
> > default yet, I noticed that the call site information wasn't added. I think
> > that this should be `ShouldEmitDebugEntryValues()`.
> I thought to restrict the production of the call site info here and only to
> allow a hand-made testing, but I think you are right, we should use the
> `ShouldEmitDebugEntryValues()`. I'll update the patch, thanks!
Thanks! It is perhaps a bit of a corner case, and we're moving towards enabling
call site info by default, but I guess this might be useful when experimenting
with adding call site info for other targets in the future.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73534/new/
https://reviews.llvm.org/D73534
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
