This revision was automatically updated to reflect the committed changes.
Closed by commit rG6fd818c5a9c5: Don't fail step out if remote server
doesn't implement qMemoryRegionInfo (authored by ted).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72513/new/
https://reviews.llvm.org/D72513
Files:
lldb/source/Target/ThreadPlanStepOut.cpp
Index: lldb/source/Target/ThreadPlanStepOut.cpp
===================================================================
--- lldb/source/Target/ThreadPlanStepOut.cpp
+++ lldb/source/Target/ThreadPlanStepOut.cpp
@@ -130,11 +130,9 @@
uint32_t permissions = 0;
if (!m_thread.GetProcess()->GetLoadAddressPermissions(m_return_addr,
permissions)) {
- m_constructor_errors.Printf("Return address (0x%" PRIx64
- ") permissions not found.",
- m_return_addr);
- LLDB_LOGF(log, "ThreadPlanStepOut(%p): %s", static_cast<void *>(this),
- m_constructor_errors.GetData());
+ LLDB_LOGF(log, "ThreadPlanStepOut(%p): Return address (0x%" PRIx64
+ ") permissions not found.", static_cast<void *>(this),
+ m_return_addr);
} else if (!(permissions & ePermissionsExecutable)) {
m_constructor_errors.Printf("Return address (0x%" PRIx64
") did not point to executable memory.",
Index: lldb/source/Target/ThreadPlanStepOut.cpp
===================================================================
--- lldb/source/Target/ThreadPlanStepOut.cpp
+++ lldb/source/Target/ThreadPlanStepOut.cpp
@@ -130,11 +130,9 @@
uint32_t permissions = 0;
if (!m_thread.GetProcess()->GetLoadAddressPermissions(m_return_addr,
permissions)) {
- m_constructor_errors.Printf("Return address (0x%" PRIx64
- ") permissions not found.",
- m_return_addr);
- LLDB_LOGF(log, "ThreadPlanStepOut(%p): %s", static_cast<void *>(this),
- m_constructor_errors.GetData());
+ LLDB_LOGF(log, "ThreadPlanStepOut(%p): Return address (0x%" PRIx64
+ ") permissions not found.", static_cast<void *>(this),
+ m_return_addr);
} else if (!(permissions & ePermissionsExecutable)) {
m_constructor_errors.Printf("Return address (0x%" PRIx64
") did not point to executable memory.",
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
