labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Actually I think this is fine. We would want to squeeze as much information as 
possible from these kinds of line tables.

I don't think fully preserving the existing behavior would be that easy, 
actually. We have another call to the llvm line table parser in 
`ParseLLVMLineTable` (line 154), but this one calls 
`DWARFDebugLine::LineTable::getOrParseLineTable` There, we already ignore (log) 
recoverable errors, and it'd be hard to tell the "new" kinds of errors from the 
"old" ones...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72158/new/

https://reviews.llvm.org/D72158



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to